update helm test #229
Merged
update helm test #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cpanato <[email protected]>
k8s-ci-robot
added
sig/testing
k8s-ci-robot
added
the
size/XS
This was referenced Apr 1, 2023
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, harshanarayana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| @@ -56,7 +56,7 @@ func TestHelmChartRepoWorkflow(t *testing.T) { | |||
| Assess("Deployment is running successfully", func(ctx context.Context, t *testing.T, config *envconf.Config) context.Context { | |||
| deployment := &appsv1.Deployment{ | |||
| ObjectMeta: v1.ObjectMeta{ | |||
| Name: "nginx-nginx-ingress", | |||
| Name: "nginx-nginx-ingress-controller", | |||
There was a problem hiding this comment.
@vladimirvivien should we have a dedicated chart pushed to the helm registry that is just meant for our test and use that instead in order to avoid failures like this one for example in the future ?
cc @cpanato
There was a problem hiding this comment.
sounds good, i can do that if you all want
|
@cpanato & @harshanarayana thanks for an awesome job!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #228
/assign @vladimirvivien @ShwethaKumbla @harshanarayana